Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Cache comparative GPU benchmarks #246

Open
samuelburnham opened this issue Jan 9, 2024 · 0 comments
Open

CI: Cache comparative GPU benchmarks #246

samuelburnham opened this issue Jan 9, 2024 · 0 comments
Labels
CI Continuous Integration related issues

Comments

@samuelburnham
Copy link
Contributor

Post-#238

Caching with gh-pages was left out of #238 due to complexity and current issues with its implementation in Lurk, e.g. lurk-lab/lurk-beta#1031. Caching benchmarks would decrease workflow time and give us a faster signal of perf improvement/regression, as well as save working time on our GPU machines.

@samuelburnham samuelburnham added the CI Continuous Integration related issues label Jan 9, 2024
huitseeker added a commit to huitseeker/arecibo that referenced this issue Jan 14, 2024
* feat: Refactor unnecessary wraps in error handling

Revised operations unnecessarily wrapping their return in a Result.

* refactor: Refactor to use infallible allocation across application

- Switched the allocation method to the infallible version, `AllocatedNum::alloc_infallible`, in multiple units (`poseidon.rs`, `bellpepper/mod.rs`, `utils.rs`, `circuit.rs`, `lib.rs`, `nifs.rs`).
  This removed the need for multiple error checks and reduced usage of `Result` return types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration related issues
Projects
None yet
Development

No branches or pull requests

1 participant