fix evaluation reversal bug

Author: huitseeker

src/lib.rs

@@ -1327,23 +1327,18 @@ mod tests {
       S<bn256::Point, ZM<halo2curves::bn256::Bn256>>,
       S<grumpkin::Point, EE<_>>,
     >();
-    test_ivc_nontrivial_with_compression_with::<
-      secp256k1::Point,
-      secq256k1::Point,
-      S<secp256k1::Point, EE<_>>,
-      S<secq256k1::Point, EE<_>>,
-    >();
-  }
-
-  #[test]
-  #[ignore]
-  fn test_ivc_nontrivial_with_zm_compression() {
     test_ivc_nontrivial_with_compression_with::<
       bn256::Point,
       grumpkin::Point,
       S<bn256::Point, ZM<halo2curves::bn256::Bn256>>,
       S<grumpkin::Point, EE<_>>,
     >();
+    test_ivc_nontrivial_with_compression_with::<
+      secp256k1::Point,
+      secq256k1::Point,
+      S<secp256k1::Point, EE<_>>,
+      S<secq256k1::Point, EE<_>>,
+    >();
   }
 
   fn test_ivc_nontrivial_with_spark_compression_with<G1, G2, E1, E2>()
@@ -1450,23 +1445,18 @@ mod tests {
     type G2 = pasta_curves::vesta::Point;
 
     test_ivc_nontrivial_with_spark_compression_with::<G1, G2, EE<_>, EE<_>>();
-    test_ivc_nontrivial_with_spark_compression_with::<
-      secp256k1::Point,
-      secq256k1::Point,
-      EE<_>,
-      EE<_>,
-    >();
-  }
-
-  #[test]
-  #[ignore]
-  fn test_ivc_nontrivial_with_spark_zm_compression() {
     test_ivc_nontrivial_with_spark_compression_with::<
       bn256::Point,
       grumpkin::Point,
       ZM<halo2curves::bn256::Bn256>,
       EE<_>,
     >();
+    test_ivc_nontrivial_with_spark_compression_with::<
+      secp256k1::Point,
+      secq256k1::Point,
+      EE<_>,
+      EE<_>,
+    >();
   }
 
   fn test_ivc_nondet_with_compression_with<G1, G2, E1, E2>()

src/provider/non_hiding_zeromorph.rs

@@ -436,8 +436,12 @@ where
     let commitment = ZMCommitment::from(UVKZGCommitment::from(*comm));
     // TODO: the following two lines will need to change base
     let polynomial = MultilinearPolynomial::new(poly.to_vec());
+
+    // Nova evaluates in lower endian, the implementation assumes big endian
+    let rev_point = point.iter().rev().cloned().collect::<Vec<_>>();
+
     let evaluation = ZMEvaluation(*eval);
-    ZMPCS::open(pk, &commitment, &polynomial, point, &evaluation, transcript)
+    ZMPCS::open(pk, &commitment, &polynomial, &rev_point, &evaluation, transcript)
   }
 
   fn verify(
@@ -450,8 +454,12 @@ where
   ) -> Result<(), NovaError> {
     let commitment = ZMCommitment::from(UVKZGCommitment::from(*comm));
     let evaluation = ZMEvaluation(*eval);
+
+    // Nova evaluates in lower endian, the implementation assumes big endian
+    let rev_point = point.iter().rev().cloned().collect::<Vec<_>>();
+
     // TODO: this clone is unsightly!
-    ZMPCS::verify(vk, transcript, &commitment, point, &evaluation, arg.clone())?;
+    ZMPCS::verify(vk, transcript, &commitment, &rev_point, &evaluation, arg.clone())?;
     Ok(())
   }
 }