-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Implement
Clone
trait for various structs (#364)
- Added `Clone` trait derivation to enhance cloning capabilities within the codebase. - Improved duplication of `CompressedSNARK` and `NIFS` structures by integrating `Clone` trait. - Optimized SNARK computations and funcs handling by cloning `CompressedSNARK` structure. This is motivated by a companion update to Lurk, where the compression mechanism requires returning a uniform type upon calling `.compress()` on a proof that can be recursive or compressed.
- Loading branch information
1 parent
b4bfe89
commit 09eb1eb
Showing
5 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09eb1eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarks
Table of Contents
Overview
This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/8338706844
Benchmark Results
RecursiveSNARK-NIVC-2
ref=b4bfe89
ref=09eb1eb
Prove-NumCons-6540
47.55 ms
(✅ 1.00x)47.39 ms
(✅ 1.00x faster)Verify-NumCons-6540
35.13 ms
(✅ 1.00x)34.84 ms
(✅ 1.01x faster)Prove-NumCons-1028888
346.59 ms
(✅ 1.00x)344.64 ms
(✅ 1.01x faster)Verify-NumCons-1028888
259.46 ms
(✅ 1.00x)256.45 ms
(✅ 1.01x faster)CompressedSNARK-NIVC-Commitments-2
ref=b4bfe89
ref=09eb1eb
Prove-NumCons-6540
13.44 s
(✅ 1.00x)13.51 s
(✅ 1.01x slower)Verify-NumCons-6540
63.15 ms
(✅ 1.00x)62.62 ms
(✅ 1.01x faster)Prove-NumCons-1028888
58.26 s
(✅ 1.00x)58.69 s
(✅ 1.01x slower)Verify-NumCons-1028888
62.36 ms
(✅ 1.00x)62.86 ms
(✅ 1.01x slower)Made with criterion-table