Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuda build feature issue #1075

Closed
cpacia opened this issue Jan 23, 2024 · 4 comments
Closed

Cuda build feature issue #1075

cpacia opened this issue Jan 23, 2024 · 4 comments

Comments

@cpacia
Copy link
Contributor

cpacia commented Jan 23, 2024

Either lurk-rs or one of its dependencies appear to be checking to see if you have the nvidia-cuda-toolkit installed locally and linking to it regardless of whether or not you use the cuda build feature.

This would possibly explain why I would notice the GPU firing even though I wasn't building with the CUDA feature flag.

I only noticed this because I'm linking to to Rust from Go via CGO and you need to set the CGO directives based on whether the rust binary is linking to cuda or not.... which is dependent on what you have installed on your system and not what build features you use. The workaround I'm using is a Go build tag where, if you have the nvidia-cuda-toolkit installed you use the build tag, if you don't you omit it.

I don't know if this is a bug but I wasn't really expecting that behavior.

@winston-h-zhang
Copy link
Contributor

This is a known issue: lurk-lang/arecibo#259

I'm actually pushing fixes as I type this 😅

@winston-h-zhang
Copy link
Contributor

@cpacia It should be fixed now, please cargo update -p grumpkin-msm

@cpacia
Copy link
Contributor Author

cpacia commented Jan 24, 2024

Thanks @winston-h-zhang I'll check it out

@samuelburnham
Copy link
Contributor

Closing as fixed by lurk-lab/grumpkin-msm#9 and lurk-lang/arecibo#279, and tested locally in lurk-rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants