Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix merge_group GPU benchmark caching on gh-pages branch #1031

Open
samuelburnham opened this issue Jan 8, 2024 · 0 comments
Open

CI: Fix merge_group GPU benchmark caching on gh-pages branch #1031

samuelburnham opened this issue Jan 8, 2024 · 0 comments
Labels
CI Related to our CI pipelines

Comments

@samuelburnham
Copy link
Contributor

Problem

Currently we write the comparative benchmark output of a merged PR to gh-pages, in order to reuse it as the baseline for the next PR. However, these benchmark JSONs can't be easily published to our gh-pages site due to incompatible BenchmarkId formats. The gh-pages benches need a date and SHA as params to be formatted correctly, while the commit-comment benches run on merge_group need the SHA in the name for differential comparison.

Solution

We need to either reconcile the two formats and publish the commit-comment benches to gh-pages (ideal solution) or move the cache somewhere else like https://github.com/actions/cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to our CI pipelines
Projects
None yet
Development

No branches or pull requests

1 participant