bellpepper-emulated: Fix overflow calculations #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of overflow had some errors. I have added a document in
emulated/docs
describing the changes. Here are some salient ones.EmulatedFieldElement::max_overflow
now returnsF::CAPACITY as usize - P::bits_per_limb() - 3
instead ofF::CAPACITY as usize - P::bits_per_limb()
next_overflow
for subtraction is changed froma.overflow.max(b.overflow + 2)
toa.overflow.max(b.overflow + 1) + 1
.sub_padding
has changed.max_value
and number of carry bits.