check multibinding key collision across modules

Author: luozejiaqun

projects/core/koin-core/src/commonMain/kotlin/org/koin/core/module/Multibinding.kt

@@ -62,6 +62,8 @@ private class MultibindingIterateKey<T>(
     val multibindingQualifier: Qualifier,
 )
 
+private val multibindingKeyCollisionDetectModule = Module()
+
 class MapMultibindingElementDefinition<K : Any, E : Any> @PublishedApi internal constructor(
     private val multibindingQualifier: Qualifier,
     private val elementClass: KClass<E>,
@@ -142,12 +144,12 @@ class MapMultibindingElementDefinition<K : Any, E : Any> @PublishedApi internal
     private fun indexPrimaryType(instanceFactory: InstanceFactory<*>): InstanceFactory<*>? {
         val def = instanceFactory.beanDefinition
         val mapping = indexKey(def.primaryType, def.qualifier, def.scopeQualifier)
-        return declareModule.mappings[mapping].apply {
+        return multibindingKeyCollisionDetectModule.mappings[mapping].apply {
             declareModule.saveMapping(mapping, instanceFactory)
+            multibindingKeyCollisionDetectModule.saveMapping(mapping, instanceFactory)
         }
     }
 
-    // TODO this only works for the same module, find a way to check across modules.
     private fun checkMultibindingKeyCollision(oldInstanceFactory: InstanceFactory<*>?, newKey: K) {
         if (oldInstanceFactory != null && needToCheckKeyType(newKey)) {
             val oldKey = (oldInstanceFactory.beanDefinition.definition(

projects/core/koin-core/src/commonTest/kotlin/org/koin/core/MapMultibindingTest.kt

@@ -272,28 +272,15 @@ class MapMultibindingTest {
     }
 
     @Test
-    fun `override map multibinding elements with different keys but same toString`() {
+    fun `get exception when overriding map multibinding elements with different keys but same toString`() {
         data class MapKey(
             val name: String,
             val value: Int,
         ) {
             override fun toString(): String = name
         }
 
-        val app = koinApplication {
-            modules(
-                module {
-                    declareMapMultibinding<MapKey, Simple.ComponentInterface1> {
-                        intoMap(MapKey(keyOfComponent1, 1)) { component1 }
-                    }
-                },
-            )
-        }
-        val koin = app.koin
-        val rootMap: Map<MapKey, Simple.ComponentInterface1> = koin.getMapMultibinding()
-        assertEquals(1, rootMap.size)
-        assertEquals(component1, rootMap[MapKey(keyOfComponent1, 1)])
-        assertNull(rootMap[MapKey(keyOfComponent1, 2)])
+        // declare in same module
         module {
             declareMapMultibinding<MapKey, Simple.ComponentInterface1> {
                 intoMap(MapKey(keyOfComponent1, 1)) { component1 }
@@ -302,6 +289,19 @@ class MapMultibindingTest {
                 }
             }
         }
+        // declare in different modules
+        module {
+            declareMapMultibinding<MapKey, Simple.ComponentInterface1> {
+                intoMap(MapKey(keyOfComponent2, 1)) { component1 }
+            }
+        }
+        module {
+            declareMapMultibinding<MapKey, Simple.ComponentInterface1> {
+                assertFailsWith(MapMultibindingKeyTypeException::class) {
+                    intoMap(MapKey(keyOfComponent2, 2)) { component1 }
+                }
+            }
+        }
     }
 
     @Test