Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add a function to sized luos_sendstreaming #142

Closed
wants to merge 13 commits into from
Closed

Fix: add a function to sized luos_sendstreaming #142

wants to merge 13 commits into from

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Jan 12, 2022 •
edited
Loading

Comments for current PR

  • add your comments here
  • ...







!!! WARNING : DO NOT EDIT THE CHECKLIST BELOW !!!

Checklist : Merge to DEVELOP branch

Code Quality

  • Each function has a header (description, inputs, outputs)
  • Code is commented (particularly in hard to understand areas)
  • There are no new warnings that can be corrected
  • Commits policy is respected (constitancy commits, clear commits comments)


Tests Review

  • Manual Tests for new features have been reviewed
  • Automatic Tests for new features have been reviewed


Tests are passed the best as I can

  • Non regression existing tests are passed OK
  • New tests for new features & bug fixes are passed OK


Documentation

  • Documentation is up to date
  • Changelog for next release is up-to-date : fill here
  • If needed, tests are briefly described in test repository

nicolas-rabault
nicolas-rabault approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Salem-Tho Salem-Tho force-pushed the fix/send_sized_streaming branch from 27a4cb4 to 052ca6c Compare January 13, 2022 16:43
@Salem-Tho Salem-Tho force-pushed the fix/send_sized_streaming branch from 0a6635b to 4059e2e Compare January 28, 2022 09:44
@Salem-Tho Salem-Tho requested a review from JeromeGalan January 28, 2022 12:36
@JeromeGalan JeromeGalan force-pushed the fix/send_sized_streaming branch from 3131062 to c9d10d2 Compare January 28, 2022 16:00
@JeromeGalan JeromeGalan deleted the fix/send_sized_streaming branch January 28, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

@JeromeGalan JeromeGalan Awaiting requested review from JeromeGalan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Salem-Tho @nicolas-rabault @JeromeGalan @mariebidouille