Skip to content

Commit 6960eb9

Browse files
akpm00sfrothwell
authored andcommitted
percpu-add-preemption-checks-to-__this_cpu-ops-fix-checkpatch-fixes
WARNING: storage class should be at the beginning of the declaration torvalds#25: FILE: lib/smp_processor_id.c:10: +notrace static unsigned int check_preemption_disabled(const char *what1, WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... torvalds#36: FILE: lib/smp_processor_id.c:42: + printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n", ERROR: space required after that ',' (ctx:VxV) torvalds#46: FILE: lib/smp_processor_id.c:56: + return check_preemption_disabled("smp_processor_id",""); ^ total: 1 errors, 2 warnings, 36 lines checked ./patches/percpu-add-preemption-checks-to-__this_cpu-ops-fix.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Christoph Lameter <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 51ab726 commit 6960eb9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: lib/smp_processor_id.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ notrace static unsigned int check_preemption_disabled(const char *what1,
5353

5454
notrace unsigned int debug_smp_processor_id(void)
5555
{
56-
return check_preemption_disabled("smp_processor_id","");
56+
return check_preemption_disabled("smp_processor_id", "");
5757
}
5858
EXPORT_SYMBOL(debug_smp_processor_id);
5959

0 commit comments

Comments
 (0)