Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CirlceCI won't recognize failure while building Gaia #2364

Closed
sabau opened this issue Mar 26, 2019 · 6 comments
Closed

CirlceCI won't recognize failure while building Gaia #2364

sabau opened this issue Mar 26, 2019 · 6 comments
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@sabau
Copy link
Contributor

sabau commented Mar 26, 2019

Describe the bug
Clearly is failing

golangci/golangci-lint debug http_download https://github.com/golangci/golangci-lint/releases/download/v1.15.0/golangci-lint-1.15.0-checksums.txt
install: cannot change permissions of ‘/go/bin’: Operation not permitted
scripts/Makefile:51: recipe for target '/go/bin/golangci-lint' failed
make: *** [/go/bin/golangci-lint] Error 1

But the build is green, we are ignoring the exit code of that command.
https://circleci.com/gh/cosmos/lunie/24088?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Expected behavior
The build job should fail

@sabau sabau added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss labels Mar 26, 2019
@sabau
Copy link
Contributor Author

sabau commented Mar 26, 2019

Seems to be related to an issue currently on the SDK https://allinbits.slack.com/archives/GBB5RM200/p1553527801025700

@sabau
Copy link
Contributor Author

sabau commented Mar 26, 2019

This needs some work on makefile side, @greg-szabo I will try to apply your lesson :)

@faboweb
Copy link
Collaborator

faboweb commented Apr 1, 2019

@mircea-c pinging for pushing all the old versions to Docker hub

@mircea-c
Copy link
Contributor

mircea-c commented Apr 1, 2019

@faboweb I'm a bit out of the loop I think. Are you talking about old versions of the SDK docker image?

@faboweb
Copy link
Collaborator

faboweb commented Apr 1, 2019

@sabau can explain

@jbibla
Copy link
Collaborator

jbibla commented Apr 30, 2019

we don't build gaia anymore so i think this can be closed.

@jbibla jbibla closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants