Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buf-move-left: Symbol’s value as variable is void: settings #18

Open
starenka opened this issue May 16, 2022 · 13 comments · May be fixed by #19
Open

buf-move-left: Symbol’s value as variable is void: settings #18

starenka opened this issue May 16, 2022 · 13 comments · May be fixed by #19

Comments

@starenka
Copy link

starenka commented May 16, 2022

Hi folks, the last commit broke my buff-move: buf-move-left: Symbol’s value as variable is void: settings
It works okay, if I revert back to this commit...

https://raw.githubusercontent.com/lukhas/buffer-move/25b7a989cf43414559717f87279654305b13e7c9/buffer-move.el

happy to provide some more info if needed

@lukhas
Copy link
Owner

lukhas commented May 16, 2022

Hello,

What is your Emacs version? I'll try to reproduce with minimal config.

@starenka
Copy link
Author

Hi lukhas,

GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2021-11-27, modified by Debian

@deescuderoo
Copy link

Having the same issue here:

GNU Emacs 28.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-04-27

@jeffpollock9
Copy link

+1 on emacs 27.2

@phlo46
Copy link

phlo46 commented Jun 10, 2022

Same here:

GNU Emacs 28.1 (build 1, x86_64-apple-darwin20.6.0, Carbon Version 164 AppKit 2022.6) of 2022-04-09

@ChauhanT
Copy link

+1 ! Occuring for me too. Emacs 27.1 on a Debian 11 system.

@zackteo
Copy link

zackteo commented Jun 15, 2022

Same here on Emacs 28.1. Right now this variant of buffer-move.el will works for me instead https://www.emacswiki.org/emacs/buffer-move.el

@JuanManuelM
Copy link

Hello, it seems that the culprit is in:

settings

If I remove the .elc file and load the .el file (or byte-compile it again), everything
works fine again (Emacs 28.1).

@aaronjensen
Copy link

Reverting this commit fixes it too: 25b7a98

@jkmingwen
Copy link

@JuanManuelM Hi, sorry, just wanted to clarify what exactly you did? Did you remove line 110 and recompile the .el file?

@starenka
Copy link
Author

Reverting this commit fixes it too: 25b7a98

as i wrote in the initial comment :P

@aaronjensen
Copy link

@starenka with respect, your initial comment included a suggestion to "revert back to this commit", which is not the same as reverting a commit. Instead, it implies resetting to that particular commit. Resetting to that commit did not fix it, because that commit was the problematic one. You could have said revert to the commit proceeding that commit or provided the hash of the proceeding commit. My suggestion was to revert the commit itself, which also fixes it.

That all said, for some reason, master works for me again on GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.5.1 (Build 21G83)) of 2022-08-20

@starenka
Copy link
Author

@aaronjensen hehe, no respect needed, we are all on same boat i guess. Nevertheless I really meant "revert to this commit", because it worked for me :D

look:

starenka /tmp % wget -q https://raw.githubusercontent.com/lukhas/buffer-move/25b7a989cf43414559717f87279654305b13e7c9/buffer-move.el -O - | diff `find ~/.emacs.d -name buffer-move.el` -
starenka /tmp % echo $?                                                                                                                                                                  
0

nevermind, im glad we all found some solution to this.

taughz added a commit to taughz/buffer-move that referenced this issue Jul 25, 2023
Using `cl-` functions requires Emacs 24.3 and the `cl-lib` package. Not
having this was causing an issue were `cl-flet` was apparently not
working correctly, which was causing error messages like:

> buf-move-right: Symbol’s value as variable is void: settings

Fixes lukhas#18
@taughz taughz linked a pull request Jul 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants