Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle newtype primitives #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

plneple
Copy link

@plneple plneple commented Jul 23, 2024

Sometimes it's useful to "mark" a primitive value as a separate type.
There are several ways to do this, but the most common goes something like this:

export type NewType<Type, Tag> = Type & {
  readonly __tag: Tag;
};

If you pass this value as a parameter to the query key, the library breaks

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 061d000

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@plneple plneple changed the title Handle newtype primitives feat: Handle newtype primitives Jul 23, 2024
@plneple
Copy link
Author

plneple commented Jul 31, 2024

@lukemorales Hey, would be nice to get feedback whether this feature is welcome in the library, and if any additional steps are needed to get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant