Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tanstack version to 5 #82

Closed
wants to merge 2 commits into from
Closed

Conversation

Gabswim
Copy link

@Gabswim Gabswim commented Nov 26, 2023

No description provided.

Copy link

changeset-bot bot commented Nov 26, 2023

⚠️ No Changeset found

Latest commit: 2b0bc9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

add prepare to be able to use from github directly
@lukemorales
Copy link
Owner

Hi @Gabswim, thanks for your contribution.

A few things:

  1. We cannot simply bump the react query version because a lot of people still are on v4, and with the breaking changes that V5 brings, it will take some time for folks, especially in a big codebase, to migrate over. So we should accept both versions.
  2. Could you explain your changes in the prepare script?

@lukemorales
Copy link
Owner

Upgrade to tanstack v5 will come in a major version currently in the works

@lukemorales lukemorales closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants