Circular references, flcone and build improvements #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Please remove all the build changes & the CI changes. PRs should be just the addition of klona/circular bits.
And remove the options on klona/circular. If someone is opting into klona/circular mode, then they're gunna get circular support. That's the point of the submodules – opting into additional behaviors. Plus it's a different API, even if it's an optional parameter.
|
Sure, didn't considered this as a valid "to merge" pr just some overall improvements I did while debugging and finding ways of giving more performance. Once I get to our ticket again to remove lodash-es/clone(deep) I will open another one. :) Just thought you wanna see what else I did since you said its out-of-scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I know you think this is out of scope maybe you are anyway interested in.
I also noticed that your gzip numbers aren't right. Seems bundlt does not calculate them correctly.
Closes: #37