Minor refactoring & new twist #5
Conversation
| int random = ThreadLocalRandom.current().nextInt(plugin.getCfg().seeds.size()); | ||
| long seed = plugin.getCfg().seeds.get(random); | ||
| this.seed = seed; | ||
| this.seed = ThreadLocalRandom.current().nextLong(); |
There was a problem hiding this comment.
This removes the seed pre-selection system
There was a problem hiding this comment.
I guess you are looking at one particular commit. It was later reverted.
| @@ -368,7 +368,7 @@ public void prepareForSpectate() { | |||
| assert player != null; | |||
| player.setInvisible(true); | |||
| reset(player, false); | |||
| player.setGameMode(GameMode.SURVIVAL); | |||
| player.setGameMode(GameMode.SPECTATOR); | |||
There was a problem hiding this comment.
This removes clickable items in hotbar as a spectator
| gp.updateScoreboard(); | ||
| gp.getCompassTracker().updateCompass(); | ||
|
|
||
| if (gp.isSpectating()) { | ||
| player.setGameMode(GameMode.SPECTATOR); |
There was a problem hiding this comment.
Unnecessary at best, or at worst, admins can't change gamemode
| @@ -89,7 +89,7 @@ public void openMenu(Player player) { | |||
| gui.setItem(i, plugin.getItemizer().FILL_ITEM); | |||
| } | |||
|
|
|||
| gui.setItem(53, plugin.getItemizer().createItem(plugin.getCfg().mainMenuStoreMaterial, 1, Util.c(plugin.getCfg().mainMenuStoreDisplayname), plugin.getCfg().mainMenuStoreLore)); | |||
| gui.setItem(53, plugin.getItemizer().FILL_ITEM); | |||
There was a problem hiding this comment.
Removes the main store menu item??
|
|
||
| public static IconConfig load(String prefix, FileConfiguration fileConfiguration) { | ||
| return new IconConfig( | ||
| fileConfiguration.getString(prefix + "-material"), |
There was a problem hiding this comment.
why not use prefix + ".material" as to use sub sections in the config?
There was a problem hiding this comment.
I guess i can do that but it will require config migrations (current keys for icons as far as i remember are ...-material, ...-displayname and ...-lore)
|
The name of the twist "get high" could also be revisited. I don't think it represents what you really want. |
|
I agree, but i can't think of a proper name for that twist |
|
I guess advancement reset should be a separate toggleable feature so this PR is not about that. |
Refactored twist menu & config to achieve less duplication
Added new twist which basically teleports players on the top block at their coordinates (to avoid spending 30+ minutes mining) - only in the overworld