You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When I start dragging the item to re-arrange the order, it always calls the onSelectItems function. On the onSelectItems call I am opening a file in a new tab (similar to vs code experience), due to this side effect the UX experience seems to be poor as the user is not intended to open the file while dragging it for re-order.
To Reproduce
pick up an item to drag
observe the onSelectItems fun
Expected behavior
On dragging the item the onSelectItems fn should not be called
Desktop (please complete the following information):
OS: iOS
Browser: chrome, safari
The text was updated successfully, but these errors were encountered:
Hi @Nishchit14, can you try to use the onPrimaryAction instead of the onSelectItems handler? That should call in those situations in which you want a call.
Thank you for the reply, Can you please share a doc or example that is available in the codebase? I've searched it but couldn't find anything other than propsonPrimaryAction: (items: TreeItem<T>, treeId: string) => void. I am not sure when this prop fn will get called.
There are no good docs on the exact logic right now, but the intent is that it calls when the user clicks on an item with probably no tree-navigation related intent. The exact logic you can see in the implementation, and is pretty much
when shift is not pressed
when control is not pressed
[when the item is not a folder, or canInvokePrimaryActionOnItemContainer is true]
You can test when it is triggered in this example. If you want to further customize which kind of user interaction triggers what, you can use custom interaction modes
for that.
Describe the bug
When I start dragging the item to re-arrange the order, it always calls the
onSelectItems
function. On theonSelectItems
call I am opening a file in a new tab (similar to vs code experience), due to this side effect the UX experience seems to be poor as the user is not intended to open the file while dragging it for re-order.To Reproduce
onSelectItems
funExpected behavior
On dragging the item the onSelectItems fn should not be called
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: