Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Update filter cache stats for latest stats API #35

Merged
merged 1 commit into from
Jul 2, 2013
Merged

Update filter cache stats for latest stats API #35

merged 1 commit into from
Jul 2, 2013

Conversation

cbcase
Copy link
Contributor

@cbcase cbcase commented Jun 15, 2013

The cache size and cache evictions graphs aren't showing up on master because the stats API changed the "cache" field to "filter_cache". This PR updates the appropriate references, so the graphs are now working again (well, locally for me :).

@lukas-vlcek
Copy link
Owner

Hey, thanks for this PR! I will do a new minor Bigdesk release with this fix included this weekend.

@lukas-vlcek
Copy link
Owner

@cbcase (cc @brusic ) Do you think you can point me to the version of ES in which this change was made? Is it since 0.90.1 or something like that? We need to update support matrix appropriately.
Thanks a lot.

@brusic
Copy link

brusic commented Jun 26, 2013

The change is required on 0.90.1. Upgraded from 0.20, so I did not test on 0.90.0 (or master). 0.90.2 was released today, so I will try it out shortly.

@cbcase
Copy link
Contributor Author

cbcase commented Jun 29, 2013

The change was made in this commit: elastic/elasticsearch@8467021#src/main/java/org/elasticsearch/index/cache/filter/FilterCacheStats.java

Based on the tags, it looks like the change was introduced in 0.90.0.

@lukas-vlcek
Copy link
Owner

Thanks.

@lukas-vlcek lukas-vlcek merged commit 8b1b426 into lukas-vlcek:master Jul 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants