Skip to content

Commit a3838ae

Browse files
authored
fix: type of zscore result should be nullable (#1639)
1 parent ddb3f89 commit a3838ae

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

Diff for: bin/returnTypes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ module.exports = {
317317
zrevrange: "string[]",
318318
zrevrangebyscore: "string[]",
319319
zrevrank: "number | null",
320-
zscore: "string",
320+
zscore: "string | null",
321321
zunion: "string[]",
322322
zmscore: "(string | null)[]",
323323
zunionstore: "number",

Diff for: lib/utils/RedisCommander.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -13854,13 +13854,13 @@ interface RedisCommander<Context extends ClientContext = { type: "default" }> {
1385413854
zscore(
1385513855
key: RedisKey,
1385613856
member: string | Buffer | number,
13857-
callback?: Callback<string>
13858-
): Result<string, Context>;
13857+
callback?: Callback<string | null>
13858+
): Result<string | null, Context>;
1385913859
zscoreBuffer(
1386013860
key: RedisKey,
1386113861
member: string | Buffer | number,
13862-
callback?: Callback<Buffer>
13863-
): Result<Buffer, Context>;
13862+
callback?: Callback<Buffer | null>
13863+
): Result<Buffer | null, Context>;
1386413864

1386513865
/**
1386613866
* Add multiple sorted sets

Diff for: test/typing/commands.test-d.ts

+4
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ expectType<Promise<number>>(redis.zadd("key", "CH", 1, "member"));
8888
expectType<Promise<string | null>>(redis.zrandmember("key"));
8989
expectType<Promise<string[]>>(redis.zrandmember("key", 20));
9090

91+
// ZSCORE
92+
expectType<Promise<string | null>>(redis.zscore("key", "member"));
93+
expectType<Promise<Buffer | null>>(redis.zscoreBuffer("key", "member"));
94+
9195
// GETRANGE
9296
expectType<Promise<Buffer>>(redis.getrangeBuffer("foo", 0, 1));
9397

0 commit comments

Comments
 (0)