Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why orientation not being used for bounding boxes on ios? #108

Closed
frodriguez-hu opened this issue Nov 1, 2024 · 4 comments
Closed

Why orientation not being used for bounding boxes on ios? #108

frodriguez-hu opened this issue Nov 1, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@frodriguez-hu
Copy link

Hi! I just wanted to know why orientation is not being used to set the bounding boxes on ios like is used on android?

@frodriguez-hu frodriguez-hu added the bug Something isn't working label Nov 1, 2024
@felire
Copy link

felire commented Nov 4, 2024

For example, I found that this

 case .left:
    return [
        "width": height,
        "height": width,
        "x": sourceWidth * scaleX - x - height + (height - width)/2,
        "y": y - (width - height)/2
    ]

is more accurate on portrait on IOS

@luicfrr
Copy link
Owner

luicfrr commented Nov 27, 2024

@felire can you open a PR with your suggestion?

@luicfrr
Copy link
Owner

luicfrr commented Jan 29, 2025

I added some commits that now seems to fix orientation issue.
Can you guys test it before I release it as a new version?

@luicfrr
Copy link
Owner

luicfrr commented Jan 31, 2025

I suppose this is fixed in c1cce1b
But we can reopen this issue if it's not

@luicfrr luicfrr closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants