-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filled versions of icons #893
Comments
I do want to use lucide icons in my lib - Anu but due to missing filled icons. I am using another icon lib. |
This would be awesome. Icons like |
@nandorojo yeah I didn't know how hard it would be, in the case of ticket I think it works well enough to be useable when its just filled but there certinly are some that seem tricky. |
yeah tbh it probably requires making new icons |
Yeah... if someone were to do that, how would they do it? Would it be a seperate SVG or would there be a way to modify it so it works with just the fill property? |
Some of these suggestions are no brainers, but some I'm not quite sure about: I think Col4 is the sure winner here, since:
|
Yeah, looking at proper versions I agree that column 4 is 100% better. And yeah, column 4 is defintely better than column 3, since in the image-cross one it creates a weird small filled area and I can imagine that will happen with other icons too. |
Ok, I spent some time trying to put the changes in column 4 into words and I think I have some rules for it: Forgive the probably bad termonolgy, I have very limited experince with vector graphics and icon design. General Rules:
Alternate Approach A: Alternate Appraoch B: |
I know this has been suggested before and it was refused because the
fill:
property does the same thing, but it dosent always. For most (probably 60-70% of the icons) it works great, no issues there. But it does break quite a few (notably the file/foleder type icons)(fill: currentColor)
And you can make th stroke/color to transparent, but I think that does more harm than good:
(fill: currentColor; color: transparent)
I'm not sure if theres an easy fix to this, or if it would require a lot of work. But it would be nice for those icons that break to work when you set a fill, so it looks good even with those.
The text was updated successfully, but these errors were encountered: