Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyLoaderSaver.Save() and MetaGetterSetter.GetAllMeta() are non-orthogonal #40

Open
hinoka opened this issue Feb 9, 2016 · 1 comment
Open

PropertyLoaderSaver.Save() and MetaGetterSetter.GetAllMeta() are non-orthogonal #40

hinoka opened this issue Feb 9, 2016 · 1 comment

Comments

@hinoka
Copy link
Contributor

hinoka commented Feb 9, 2016

Save(withMeta bool) (PropertyMap, error) should just deal with contents and GetAllMeta() PropertyMap should just deal with metadata.
@riannucci riannucci changed the title PropertyLoaderSaver.Save() and MetaGetterSetter.GetAllMeta() is redundant PropertyLoaderSaver.Save() and MetaGetterSetter.GetAllMeta() are non-orthogonal Mar 16, 2016
@riannucci
Copy link
Member

@danjacques I think you fixed this already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riannucci @hinoka