Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datastore's IndexColumn Property and Descending fields be their own types #38

Open
nishanths opened this issue Jan 14, 2016 · 1 comment
Open

Make datastore's IndexColumn Property and Descending fields be their own types #38

nishanths opened this issue Jan 14, 2016 · 1 comment

Comments

@nishanths
Copy link
Contributor

The Property and Descending fields are currently a string and bool respectively.
Making them their own types and implementing their own Marshal/Unmarshal functions would result in cleaner marshlling/unmarshalling code.

From: https://chromiumcodereview.appspot.com/1574353004/diff/1/service/datastore/index.go#newcode55
@riannucci
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riannucci @nishanths