-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log repositories not matching requirements #206
Comments
Hey @zillemarco, sounds interesting. It will definitely simplify the filtering process. Where would you like that to be logged? |
Do you mean where to create the log file with the actual logs, or where to log the data inside the code? 🤔 For the file, I thing we can stick with But I'm sure @lucavallin would be able to tell you if that's ok or if there are better ways/places 🙂 |
@dnafication agree with @zillemarco. We just need a way to see repos that don't meet criteria (anymore). Maybe in the Actions workflow summary would be a reasonable place for that. |
Great! I have some ideas around refactoring the |
Hey @lucavallin @zillemarco, I was thinking of introducing
@lucavallin you might need to update Vercel's deployment config to support these changes so let me know if its worth a change. |
At first, my idea was to record comprehensive information regarding why a repository didn't meet the criteria. However, it appears that filtering occurs at various stages, such as during the GraphQL query and subsequent processing of its results. Now, I'm planning to generate a comparison between the original list and the filtered list and logging only that information. Do you believe this would suffice, or should we still include specifics about why a particular repository failed to meet the criteria? Perhaps, this can be the initial iteration and we can add more logic to it. I have made the code modular and refactored the main script to make it readable. I'll send the PR soon. |
@dnafication I am happy to add the |
Since we have multiple reasons why a project is not added (namely stars count and issues count) and we have different places where we do filter those out (for GitHub is a mix of GraphQL query and manual filter, for GitLab is only manual filter).
Probably, a good way to handle this would do all the queries and then iterate over the repos coming from a source and see if it's there or not, and log those results.
Originally posted by @zillemarco in #171 (comment)
The text was updated successfully, but these errors were encountered: