Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always reset header buffer, even when QPACK encoding fails #3436

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #3436 (afc68f9) into master (b5ef99a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   85.69%   85.70%   +0.02%     
==========================================
  Files         135      135              
  Lines        9955     9954       -1     
==========================================
+ Hits         8530     8531       +1     
+ Misses       1048     1047       -1     
+ Partials      377      376       -1     
Impacted Files Coverage Δ
http3/request_writer.go 64.34% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef99a...afc68f9. Read the comment docs.

@marten-seemann marten-seemann merged commit 9dfe9d5 into master Jun 9, 2022
@marten-seemann marten-seemann deleted the fix-qpack-buffer-reset branch June 9, 2022 08:50
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants