Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various amplification limit fixes #3132

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Conversation

marten-seemann
Copy link
Member

Fixes #3053.

  1. When becoming amplification limited, we don't need to set a loss recovery timer. All we can do at that point is wait for a packet from the client to arrive.
  2. Once that packet arrives, we need to restart the loss recovery timer.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3132 (b6634fe) into master (3376a9f) will decrease coverage by 0.01%.
The diff coverage is 78.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3132      +/-   ##
==========================================
- Coverage   85.48%   85.47%   -0.01%     
==========================================
  Files         131      131              
  Lines        9650     9663      +13     
==========================================
+ Hits         8249     8259      +10     
- Misses       1033     1035       +2     
- Partials      368      369       +1     
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 77.91% <77.78%> (+0.22%) ⬆️
session.go 77.10% <100.00%> (ø)
internal/utils/rand.go 62.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3376a9f...b6634fe. Read the comment docs.

@marten-seemann marten-seemann merged commit 4b10e67 into master Apr 2, 2021
@marten-seemann marten-seemann deleted the amplification-limit-fixes branch April 3, 2021 01:35
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate recent loss recovery change
2 participants