don't reset the QPACK encoder / decoder streams #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3063 +/- ##
==========================================
+ Coverage 86.05% 86.05% +0.01%
==========================================
Files 133 133
Lines 9438 9442 +4
==========================================
+ Hits 8121 8125 +4
Misses 955 955
Partials 362 362
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
dont-reset-qpack-streams
branch
from
b65f000
to
74b922e
Compare
We don't need these streams, since our QPACK implementation doesn't use the dynamic table yet. However, we MUST NOT close / reset these streams. Instead, just ignore them.
marten-seemann
force-pushed
the
dont-reset-qpack-streams
branch
from
74b922e
to
6f32d2d
Compare
lucas-clemente
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need these streams, since our QPACK implementation doesn't use the dynamic table yet. However, we MUST NOT close / reset these streams. Instead, just ignore them.