allow access to the underlying quic.Stream from a http.ResponseWriter #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2993 +/- ##
==========================================
+ Coverage 86.12% 86.88% +0.76%
==========================================
Files 135 135
Lines 9379 10055 +676
==========================================
+ Hits 8077 8736 +659
- Misses 943 959 +16
- Partials 359 360 +1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jan 15, 2021
http3/response_writer.go
Outdated
| // | ||
| // It becomes the caller's responsibility to manage and close the connection. | ||
| // | ||
| // After a call to DataStreamer, the original Request.Body must not be used. |
http3/response_writer.go
Outdated
| "github.com/lucas-clemente/quic-go/internal/utils" | ||
| "github.com/marten-seemann/qpack" | ||
| ) | ||
|
|
||
| // DataStreamer lets the caller take over the stream. After a call to DataStreamer |
marten-seemann
force-pushed
the
response-writer-data-streamer
branch
from
98296e8
to
35939b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1492.