Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a http3.RoundTripOpt to skip the request scheme check #2962

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

marten-seemann
Copy link
Member

Otherwise, we'll only be able to issue https requests. This is what we usually want, but for MASQUE support, the URL will be of the form masque://example.org.

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #2962 (c78634d) into master (b47fe87) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   86.18%   85.89%   -0.29%     
==========================================
  Files         134      135       +1     
  Lines        9364     9466     +102     
==========================================
+ Hits         8070     8130      +60     
- Misses        935      975      +40     
- Partials      359      361       +2     
Impacted Files Coverage Δ
http3/roundtrip.go 93.33% <100.00%> (ø)
internal/qtls/go115.go 33.33% <0.00%> (-13.33%) ⬇️
internal/qtls/go114.go 22.22% <0.00%> (-3.70%) ⬇️
internal/qtls/go116.go 46.67% <0.00%> (ø)
http3/server.go 69.88% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47fe87...c78634d. Read the comment docs.

http3/roundtrip.go Show resolved Hide resolved
Otherwise, we'll only be able to issue https requests. This is what we
usually want, but for MASQUE support, the URL will be of the form
masque://example.org.
@marten-seemann marten-seemann merged commit 5e7fb50 into master Jan 2, 2021
@marten-seemann marten-seemann deleted the skip-scheme-check branch January 2, 2021 04:07
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants