Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate check of the URL scheme in the HTTP/3 client #2956

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

marten-seemann
Copy link
Member

There's already a check like this performed in the http3.RoundTripper.

There's already a check like this performed in the http3.RoundTripper.
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #2956 (7e4ac36) into master (68e8c4d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2956      +/-   ##
==========================================
- Coverage   86.18%   86.18%   -0.00%     
==========================================
  Files         134      134              
  Lines        9364     9362       -2     
==========================================
- Hits         8070     8068       -2     
  Misses        935      935              
  Partials      359      359              
Impacted Files Coverage Δ
http3/client.go 88.54% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e8c4d...7e4ac36. Read the comment docs.

@marten-seemann marten-seemann merged commit 052d0b2 into master Dec 29, 2020
@marten-seemann marten-seemann deleted the remove-duplicate-scheme-check branch December 29, 2020 01:20
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants