add support for Go 1.16 #2953
add support for Go 1.16 #2953
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2953 +/- ##
==========================================
- Coverage 86.18% 86.09% -0.09%
==========================================
Files 134 134
Lines 9364 9462 +98
==========================================
+ Hits 8070 8146 +76
- Misses 935 951 +16
- Partials 359 365 +6
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
go116
branch
from
a1b29df
to
61664b8
Compare
.github/workflows/cross-compile.yml
Outdated
| runs-on: ubuntu-latest | ||
| name: "Cross Compilation (Go ${{matrix.go}})" | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-go@v2 | ||
| with: | ||
| stable: contains(${{ matrix.go }}, "beta") || contains(${{ matrix.go }}, "rc") |
There was a problem hiding this comment.
should this not be "unstable" or "prerelease"?
There was a problem hiding this comment.
Not sure what you mean, but I think I go the condition here wrong (need to negate it).
There was a problem hiding this comment.
Yeah, that's what I mean. The logic you have is the opposite of stable, so I was suggesting names.
There was a problem hiding this comment.
stable is defined by the setup-go, so we can't change that. I agree with you that it would be better if a boolean option with a default would default to false, but maybe that's a too Go-y way of thinking.
marten-seemann
force-pushed
the
go116
branch
2 times, most recently
from
b73a00c
to
f6de076
Compare
marten-seemann
force-pushed
the
go116
branch
from
f6de076
to
57e3f55
Compare
@mvdan FYI.
As always, the most important change here is the rebase of the qtls changes on top the new crypto/tls.
Regarding new features in Go 1.16, the only thing I'm currently aware of is using
net.ErrClosed(see #2933).