Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Go 1.16 #2953

Merged
merged 1 commit into from
Dec 30, 2020
Merged

add support for Go 1.16 #2953

merged 1 commit into from
Dec 30, 2020

Conversation

marten-seemann
Copy link
Member

@mvdan FYI.

As always, the most important change here is the rebase of the qtls changes on top the new crypto/tls.
Regarding new features in Go 1.16, the only thing I'm currently aware of is using net.ErrClosed (see #2933).

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #2953 (f6de076) into master (68e8c4d) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2953      +/-   ##
==========================================
- Coverage   86.18%   86.09%   -0.09%     
==========================================
  Files         134      134              
  Lines        9364     9462      +98     
==========================================
+ Hits         8070     8146      +76     
- Misses        935      951      +16     
- Partials      359      365       +6     
Impacted Files Coverage Δ
internal/qtls/go114.go 25.93% <ø> (ø)
internal/qtls/go115.go 46.67% <ø> (ø)
http3/server.go 68.34% <0.00%> (-0.36%) ⬇️
http3/client.go 89.50% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e8c4d...57e3f55. Read the comment docs.

Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment on the TLS code, but the rest looks good.

runs-on: ubuntu-latest
name: "Cross Compilation (Go ${{matrix.go}})"
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
stable: contains(${{ matrix.go }}, "beta") || contains(${{ matrix.go }}, "rc")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be "unstable" or "prerelease"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean, but I think I go the condition here wrong (need to negate it).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I mean. The logic you have is the opposite of stable, so I was suggesting names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable is defined by the setup-go, so we can't change that. I agree with you that it would be better if a boolean option with a default would default to false, but maybe that's a too Go-y way of thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants