remove unneeded check for the peer's transport parameters #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create a new flow controller when opening a new streams. This can only happen after the session is returned, in which case we should have already received the transport parameters.
Codecov Report
@@ Coverage Diff @@
## master #2945 +/- ##
==========================================
+ Coverage 86.04% 86.07% +0.03%
==========================================
Files 134 134
Lines 9286 9283 -3
==========================================
Hits 7990 7990
+ Misses 938 935 -3
Partials 358 358
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a new flow controller when opening a new streams. This can only happen after the session is returned, in which case we should have already received the transport parameters (this also applies to the 0-RTT case).