fix a crash in the http3.Server when GetConfigForClient returns nil #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinliming2
reviewed
Dec 3, 2020
| @@ -149,6 +149,9 @@ func (s *Server) serveImpl(tlsConf *tls.Config, conn net.PacketConn) error { | |||
| return nil, err | |||
| } | |||
| } | |||
| if conf == nil { | |||
| return nil, nil | |||
| } | |||
There was a problem hiding this comment.
NextProtos may not be set if return immediately?
There was a problem hiding this comment.
Good catch. Should be fixed now.
marten-seemann
force-pushed
the
fix-http3-server-getconfigforclient-nil
branch
from
0ff5809
to
9f14d82
Compare
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
- Coverage 85.77% 85.76% -0.02%
==========================================
Files 133 133
Lines 9180 9184 +4
==========================================
+ Hits 7874 7876 +2
- Misses 958 959 +1
- Partials 348 349 +1
Continue to review full report at Codecov.
|
mvdan
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2924.