fix race condition when accepting streams #2874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening here is the following: In
AcceptStream
we check if the stream we want to return already exists: https://github.com/lucas-clemente/quic-go/blob/629272c7138e9f2824d5cbf5d629e801339301d7/streams_map_incoming_generic.go#L64-L73It does not. Before advance to the
select
statement, the go routine is preempted andGetOrOpenStream
is called and the stream is created. SincenewStreamChan
is an unbuffered channel,GetOrOpenStream
doesn't send on that channel:https://github.com/lucas-clemente/quic-go/blob/629272c7138e9f2824d5cbf5d629e801339301d7/streams_map_incoming_generic.go#L116-L122
Now
AcceptStream
will never return the stream, as it's now blocking on theselect
statement.The solution is simple: make
newStreamChan
a channel of capacity 1.