Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow the HTTP/3 client to dial with a single QUIC version #2848

Merged
merged 3 commits into from
Nov 2, 2020

Conversation

marten-seemann
Copy link
Member

This is an unfortunate outcome, but we don't have any way to set the ALPN value based on the QUIC version in the client. It's better to throw an error than to offer an invalid combination of ALPN and QUIC version.

Depends on #2847.

@marten-seemann marten-seemann force-pushed the http3-client-versions branch 2 times, most recently from 315c2bf to cd2e6c4 Compare October 29, 2020 09:02
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #2848 into master will decrease coverage by 0.13%.
The diff coverage is 52.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
- Coverage   85.80%   85.67%   -0.13%     
==========================================
  Files         134      134              
  Lines        9065     9087      +22     
==========================================
+ Hits         7778     7785       +7     
- Misses        946      960      +14     
- Partials      341      342       +1     
Impacted Files Coverage Δ
internal/qtls/go114.go 25.93% <0.00%> (-24.07%) ⬇️
internal/qtls/go115.go 46.67% <0.00%> (-3.33%) ⬇️
http3/roundtrip.go 93.22% <50.00%> (-3.21%) ⬇️
http3/server.go 65.00% <66.67%> (+0.14%) ⬆️
http3/client.go 86.92% <100.00%> (+0.74%) ⬆️
internal/protocol/version.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b034f1a...898f484. Read the comment docs.

@marten-seemann marten-seemann force-pushed the http3-client-versions branch 6 times, most recently from 4c22e90 to 66fcb2d Compare November 2, 2020 04:20
@marten-seemann marten-seemann merged commit 272229a into master Nov 2, 2020
@marten-seemann marten-seemann deleted the http3-client-versions branch November 2, 2020 05:40
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants