Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qlog the key phase bit #2817

Merged
merged 2 commits into from
Oct 6, 2020
Merged

qlog the key phase bit #2817

merged 2 commits into from
Oct 6, 2020

Conversation

marten-seemann
Copy link
Member

Without that information it's just impossible to debug key update failures, see quicwg/qlog#118.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2817 into master will decrease coverage by 0.00%.
The diff coverage is 86.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2817      +/-   ##
==========================================
- Coverage   85.93%   85.92%   -0.00%     
==========================================
  Files         133      133              
  Lines       12087    12098      +11     
==========================================
+ Hits        10386    10395       +9     
- Misses       1366     1368       +2     
  Partials      335      335              
Impacted Files Coverage Δ
internal/protocol/key_phase.go 85.71% <81.82%> (-14.29%) ⬇️
qlog/packet_header.go 95.83% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75da79...d5a3022. Read the comment docs.

@marten-seemann marten-seemann merged commit 5d2b87e into master Oct 6, 2020
@marten-seemann marten-seemann deleted the qlog-key-phase-bit branch October 6, 2020 13:32
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants