-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Add DialEarlyContext and DialAddrEarlyContext API #2814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
- Coverage 86.02% 83.72% -2.30%
==========================================
Files 133 275 +142
Lines 12063 22189 +10126
==========================================
+ Hits 10376 18576 +8200
- Misses 1355 2906 +1551
- Partials 332 707 +375
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This lgtm, just one suggestion:
Can you use DialAddrEarlyContext
in DialAddrEarly
, in order to avoid code duplication?
func DialAddrEarly(...) {
return DialAddrEarlyContext(context.Background(), ....)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #2812.