Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for the ECN test case #2793

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 21, 2020

The interop runner test case requires us to proactively set ECN bits, which we currently don't do (see #2789).

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #2793 into master will decrease coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2793      +/-   ##
==========================================
- Coverage   86.92%   86.11%   -0.81%     
==========================================
  Files         133      133              
  Lines       10106     8956    -1150     
==========================================
- Hits         8784     7712    -1072     
+ Misses        990      913      -77     
+ Partials      332      331       -1     
Impacted Files Coverage Δ
internal/testdata/cert.go 57.89% <0.00%> (-8.77%) ⬇️
internal/utils/buffered_write_closer.go 66.67% <0.00%> (-8.33%) ⬇️
internal/wire/handshake_done_frame.go 50.00% <0.00%> (-5.56%) ⬇️
http3/response_writer.go 70.00% <0.00%> (-5.00%) ⬇️
internal/handshake/header_protector.go 78.26% <0.00%> (-4.79%) ⬇️
internal/handshake/token_protector.go 54.29% <0.00%> (-4.69%) ⬇️
internal/protocol/connection_id.go 81.82% <0.00%> (-4.39%) ⬇️
closed_session.go 79.41% <0.00%> (-4.31%) ⬇️
http3/request_writer.go 61.87% <0.00%> (-3.26%) ⬇️
http3/frames.go 74.60% <0.00%> (-3.17%) ⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e0db8...960fd8b. Read the comment docs.

@marten-seemann
Copy link
Member Author

Codecov is going crazy again. No idea why it thinks that this would reduce code coverage...

@marten-seemann marten-seemann merged commit 7bacb14 into master Sep 21, 2020
@marten-seemann marten-seemann deleted the remove-interop-ecn-test branch September 21, 2020 05:56
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant