Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropping of 0-RTT packets #2752

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

marten-seemann
Copy link
Member

Fixed version of #2749.

Iterate so far didn't allow to remove packets from the packet history, but we still did that for removing 0-RTT packets:
https://github.com/lucas-clemente/quic-go/blob/bed802aee5732c8fe373bf4f71e789bea2f7f11f/internal/ackhandler/sent_packet_handler.go#L158-L166

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2752 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
+ Coverage   86.52%   86.54%   +0.02%     
==========================================
  Files         128      128              
  Lines        9960     9962       +2     
==========================================
+ Hits         8617     8621       +4     
+ Misses       1010     1009       -1     
+ Partials      333      332       -1     
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_history.go 100.00% <100.00%> (ø)
internal/ackhandler/sent_packet_handler.go 73.54% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed802a...ad40c9c. Read the comment docs.

@marten-seemann marten-seemann merged commit d89a446 into master Sep 9, 2020
@marten-seemann marten-seemann deleted the fix-0rtt-packets-dropping branch September 9, 2020 16:23
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants