Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unacknowledged packets from the packet history after 3 PTOs #2750

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

marten-seemann
Copy link
Member

This is a fairly big change how we keep track of sent packets. We used to evict packets from the history once they got acknowledged or declared lost.
With this change, packets are only evicted when they are acknowledged. When a packet is declared lost, we still keep it in the history. This allows us generate RTT measurements for packets that were spuriously declared lost.
Packets are now deleted from the history after 3 PTOs (and only if they have been declared lost before).

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2750 into master will increase coverage by 0.03%.
The diff coverage is 92.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
+ Coverage   86.69%   86.71%   +0.03%     
==========================================
  Files         128      128              
  Lines       10013    10033      +20     
==========================================
+ Hits         8680     8700      +20     
  Misses       1006     1006              
  Partials      327      327              
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 74.25% <87.50%> (+0.34%) ⬆️
internal/ackhandler/sent_packet_history.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81eeb8...8f4257a. Read the comment docs.

@marten-seemann marten-seemann merged commit 74f2610 into master Sep 11, 2020
@marten-seemann marten-seemann deleted the rtt-measurement-for-lost-packets branch September 11, 2020 04:00
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants