Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only close the handshake fuzz runner once #2740

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

marten-seemann
Copy link
Member

This should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25400.

What's happening here is the following: The client receives an EncryptedExtensions message that contains an invalid QUIC Transport Parameter extension as well as an invalid ALPN. The TLS stack therefore sends a TLS alert, while the QUIC stack at the same time throws a TRANSPORT_PARAMETER error.

As the TLS handshake is running in its own Go routine, which of these errors occurs first is undefined, and the QUIC specification doesn't require any order here. The important thing here is that only the first of these errors should be processed (in the case of a QUIC connection, it would be sent out in a CONNECTION_CLOSE frame). The fuzz setup should reflect this.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #2740 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2740   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files         128      128           
  Lines        9960     9960           
=======================================
  Hits         8617     8617           
  Misses       1010     1010           
  Partials      333      333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd78ea9...8251b36. Read the comment docs.

@marten-seemann marten-seemann merged commit 561ac68 into master Sep 4, 2020
@marten-seemann marten-seemann deleted the fix-handshake-fuzz-double-close branch September 5, 2020 04:16
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant