Merge remote-tracking branch 'upstream/master'

Author: losh11

.github/workflows/go.yml

@@ -1,27 +1,74 @@
 name: Build and Test
 on: [push, pull_request]
+
+env:
+  # go needs absolute directories, using the $HOME variable doesn't work here.
+  GOCACHE: /home/runner/work/go/pkg/build
+  GOPATH: /home/runner/work/go
+  GO_VERSION: 1.17.5
+
 jobs:
   build:
-    name: Go CI
+    name: Build
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: [1.13, 1.14]
     steps:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: ${{ matrix.go }}
+          go-version: ${{ env.GO_VERSION }}
+
       - name: Check out source
         uses: actions/checkout@v2
-      - name: Install Linters
-        run: "curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.26.0"
+
       - name: Build
-        env:
-          GO111MODULE: "on"
-        run: go build ./...
+        run: make build
+
+  test-cover:
+    name: Unit coverage
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ env.GO_VERSION }}
+
+      - name: Check out source
+        uses: actions/checkout@v2
+
+      - name: Test
+        run: make unit-cover
+
+      - name: Send top-level coverage
+        uses: shogo82148/actions-goveralls@v1
+        with:
+          path-to-profile: coverage.txt
+
+      - name: Send btcec
+        uses: shogo82148/actions-goveralls@v1
+        with:
+          path-to-profile: btcec/coverage.txt
+
+      - name: Send btcutil coverage
+        uses: shogo82148/actions-goveralls@v1
+        with:
+          path-to-profile: btcutil/coverage.txt
+
+      - name: Send btcutil coverage for psbt package
+        uses: shogo82148/actions-goveralls@v1
+        with:
+          path-to-profile: btcutil/psbt/coverage.txt
+
+  test-race:
+    name: Unit race
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ env.GO_VERSION }}
+
+      - name: Check out source
+        uses: actions/checkout@v2
+
       - name: Test
-        env:
-          GO111MODULE: "on"
-        run: |
-          sh ./goclean.sh
+        run: make unit-race

.gitignore

@@ -33,3 +33,11 @@ _testmain.go
 
 ltcd
 *.exe
+
+# Code coverage files
+profile.tmp
+profile.cov
+coverage.txt
+btcec/coverage.txt
+btcutil/coverage.txt
+btcutil/psbt/coverage.txt

CHANGES

@@ -3,6 +3,281 @@ User visible changes for ltcd
   A full-node bitcoin implementation written in Go
 ============================================================================
 
+Changes in 0.22.0 (Tue Jun 01 2021)
+  - Protocol and network-related changes:
+    - Add support for witness tx and block in notfound msg (#1625)
+    - Add support for receiving sendaddrv2 messages from a peer (#1670)
+    - Fix bug in peer package causing last block height to go backwards
+      (#1606)
+    - Add chain parameters for connecting to the public Signet network
+      (#1692, #1718)
+  - Crypto changes:
+    - Fix bug causing panic due to bad R and S signature components in
+      btcec.RecoverCompact (#1691)
+    - Set the name (secp256k1) in the CurveParams of the S256 curve
+      (#1565)
+  - Notable developer-related package changes:
+    - Remove unknown block version warning in the blockchain package,
+      due to false positives triggered by AsicBoost (#1463)
+    - Add chaincfg.RegisterHDKeyID function to populate HD key ID pairs
+      (#1617)
+    - Add new method mining.AddWitnessCommitment to add the witness
+      commitment as an OP_RETURN output within the coinbase transaction.
+      (#1716)
+  - RPC changes:
+    - Support Batch JSON-RPC in rpcclient and server (#1583)
+    - Add rpcclient method to invoke getdescriptorinfo JSON-RPC command
+      (#1578)
+    - Update the rpcserver handler for validateaddress JSON-RPC command to
+      have parity with the bitcoind 0.20.0 interface (#1613)
+    - Add rpcclient method to invoke getblockfilter JSON-RPC command
+      (#1579)
+    - Add signmessagewithprivkey JSON-RPC command in rpcserver (#1585)
+    - Add rpcclient method to invoke importmulti JSON-RPC command (#1579)
+    - Add watchOnly argument in rpcclient method to invoke
+      listtransactions JSON-RPC command (#1628)
+    - Update btcjson.ListTransactionsResult for compatibility with Bitcoin
+      Core 0.20.0 (#1626)
+    - Support nullable optional JSON-RPC parameters (#1594)
+    - Add rpcclient and server method to invoke getnodeaddresses JSON-RPC
+      command (#1590)
+    - Add rpcclient methods to invoke PSBT JSON-RPC commands (#1596)
+    - Add rpcclient method to invoke listsinceblock with the
+      include_watchonly parameter enabled (#1451)
+    - Add rpcclient method to invoke deriveaddresses JSON-RPC command
+      (#1631)
+    - Add rpcclient method to invoke getblocktemplate JSON-RPC command
+      (#1629)
+    - Add rpcclient method to invoke getaddressinfo JSON-RPC command
+      (#1633)
+    - Add rpcclient method to invoke getwalletinfo JSON-RPC command
+      (#1638)
+    - Fix error message in rpcserver when an unknown RPC command is
+      encountered (#1695)
+    - Fix error message returned by estimatefee when the number of blocks
+      exceeds the max depth (#1678)
+    - Update btcjson.GetBlockChainInfoResult to include new fields in
+      Bitcoin Core (#1676)
+    - Add ExtraHeaders in rpcclient.ConnConfig struct (#1669)
+    - Fix bitcoind compatibility issue with the sendrawtransaction
+      JSON-RPC command (#1659)
+    - Add new JSON-RPC errors to btcjson package, and documented them
+      (#1648)
+    - Add rpcclient method to invoke createwallet JSON-RPC command
+      (#1650)
+    - Add rpcclient methods to invoke backupwallet, dumpwallet, loadwallet
+      and unloadwallet JSON-RPC commands (#1645)
+    - Fix unmarshalling error in getmininginfo JSON-RPC command, for valid
+      integers in scientific notation (#1644)
+    - Add rpcclient method to invoke gettxoutsetinfo JSON-RPC command
+      (#1641)
+    - Add rpcclient method to invoke signrawtransactionwithwallet JSON-RPC
+      command (#1642)
+    - Add txid to getblocktemplate response of rpcserver (#1639)
+    - Fix monetary unit used in createrawtransaction JSON-RPC command in
+      rpcserver (#1614)
+    - Add rawtx field to btcjson.GetBlockVerboseTxResult to provide
+      backwards compatibility with older versions of Bitcoin Core (#1677)
+  - Misc changes:
+    - Update btcutil dependency (#1704)
+    - Add Dockerfile to build and run btcd on Docker (#1465)
+    - Rework documentation and publish on https://btcd.readthedocs.io (#1468)
+    - Add support for Go 1.15 (#1619)
+    - Add Go 1.14 as the minimum supported version of Golang (#1621)
+  - Contributors (alphabetical order):
+    - 10gic
+    - Andrew Tugarinov
+    - Anirudha Bose
+    - Appelberg-s
+    - Armando Ochoa
+    - Aurèle Oulès
+    - Calvin Kim
+    - Christian Lehmann
+    - Conner Fromknecht
+    - Dan Cline
+    - David Mazary
+    - Elliott Minns
+    - Federico Bond
+    - Friedger Müffke
+    - Gustavo Chain
+    - Hanjun Kim
+    - Henry Fisher
+    - Iskander Sharipov
+    - Jake Sylvestre
+    - Johan T. Halseth
+    - John C. Vernaleo
+    - Liran Sharir
+    - Mikael Lindlof
+    - Olaoluwa Osuntokun
+    - Oliver Gugger
+    - Rjected
+    - Steven Kreuzer
+    - Torkel Rogstad
+    - Tristyn
+    - Victor Lavaud
+    - Vinayak Borkar
+    - Wilmer Paulino
+    - Yaacov Akiba Slama
+    - ebiiim
+    - ipriver
+    - wakiyamap
+    - yyforyongyu
+
+Changes in 0.21.0 (Thu Aug 27 2020)
+  - Network-related changes:
+    - Handle notfound messages from peers in netsync package (#1603)
+  - RPC changes:
+    - Add compatibility for getblock RPC changes in bitcoind 0.15.0 (#1529)
+    - Add new optional Params field to rpcclient.ConnConfig (#1467)
+    - Add new error code ErrRPCInWarmup in btcjson (#1541)
+    - Add compatibility for changes to getmempoolentry response in bitcoind
+      0.19.0 (#1524)
+    - Add rpcclient methods for estimatesmartfee and generatetoaddress
+      commands (#1500)
+    - Add rpcclient method for getblockstats command (#1500)
+    - Parse serialized transaction from createrawtransaction command using
+      both segwit, and legacy format (#1502)
+    - Support cookie-based authentication in rpcclient (#1460)
+    - Add rpcclient method for getchaintxstats command (#1571)
+    - Add rpcclient method for fundrawtransaction command (#1553)
+    - Add rpcclient method for getbalances command (#1595)
+    - Add new method rpcclient.GetTransactionWatchOnly (#1592)
+  - Crypto changes:
+    - Fix panic in fieldVal.SetByteSlice when called with large values, and
+      improve the method to be 35% faster (#1602)
+  - btcctl changes:
+    - Add -regtest mode to btcctl (#1556)
+  - Misc changes:
+    - Fix a bug due to a deadlock in connmgr's dynamic ban scoring (#1509)
+    - Add blockchain.NewUtxoEntry() to directly create entries for
+      UtxoViewpoint (#1588)
+    - Replace LRU cache implementation in peer package with a generic one
+      from decred/dcrd (#1599)
+  - Contributors (alphabetical order):
+    - Anirudha Bose
+    - Antonin Hildebrand
+    - Dan Cline
+    - Daniel McNally
+    - David Hill
+    - Federico Bond
+    - George Tankersley
+    - Henry
+    - Henry Harder
+    - Iskander Sharipov
+    - Ivan Kuznetsov
+    - Jake Sylvestre
+    - Javed Khan
+    - JeremyRand
+    - Jin
+    - John C. Vernaleo
+    - Kulpreet Singh
+    - Mikael Lindlof
+    - Murray Nesbitt
+    - Nisen
+    - Olaoluwa Osuntokun
+    - Oliver Gugger
+    - Steven Roose
+    - Torkel Rogstad
+    - Tyler Chambers
+    - Wilmer Paulino
+    - Yash Bhutwala
+    - adiabat
+    - jalavosus
+    - mohanson
+    - qqjettkgjzhxmwj
+    - qshuai
+    - shuai.qi
+    - tpkeeper
+
+Changes in v0.20.1 (Wed Nov 13 2019)
+  - RPC changes:
+    - Add compatibility for bitcoind v0.19.0 in rpcclient and btcjson
+      packages (#1484)
+  - Contributors (alphabetical order):
+    - Eugene Zeigel
+    - Olaoluwa Osuntokun
+    - Wilmer Paulino
+
+Changes in v0.20.0 (Tue Oct 15 2019)
+  - Significant changes made since 0.12.0. See git log or refer to release
+    notes on GitHub for full details.
+  - Contributors (alphabetical order):
+    - Albert Puigsech Galicia
+    - Alex Akselrod
+    - Alex Bosworth
+    - Alex Manuskin
+    - Alok Menghrajani
+    - Anatoli Babenia
+    - Andy Weidenbaum
+    - Calvin McAnarney
+    - Chris Martin
+    - Chris Pacia
+    - Chris Shepherd
+    - Conner Fromknecht
+    - Craig Sturdy
+    - Cédric Félizard
+    - Daniel Krawisz
+    - Daniel Martí
+    - Daniel McNally
+    - Dario Nieuwenhuis
+    - Dave Collins
+    - David Hill
+    - David de Kloet
+    - GeertJohan
+    - Grace Noah
+    - Gregory Trubetskoy
+    - Hector Jusforgues
+    - Iskander (Alex) Sharipov
+    - Janus Troelsen
+    - Jasper
+    - Javed Khan
+    - Jeremiah Goyette
+    - Jim Posen
+    - Jimmy Song
+    - Johan T. Halseth
+    - John C. Vernaleo
+    - Jonathan Gillham
+    - Josh Rickmar
+    - Jon Underwood
+    - Jonathan Zeppettini
+    - Jouke Hofman
+    - Julian Meyer
+    - Kai
+    - Kamil Slowikowski
+    - Kefkius
+    - Leonardo Lazzaro
+    - Marco Peereboom
+    - Marko Bencun
+    - Mawueli Kofi Adzoe
+    - Michail Kargakis
+    - Mitchell Paull
+    - Nathan Bass
+    - Nicola 'tekNico' Larosa
+    - Olaoluwa Osuntokun
+    - Pedro Martelletto
+    - Ricardo Velhote
+    - Roei Erez
+    - Ruben de Vries
+    - Rune T. Aune
+    - Sad Pencil
+    - Shuai Qi
+    - Steven Roose
+    - Tadge Dryja
+    - Tibor Bősze
+    - Tomás Senart
+    - Tzu-Jung Lee
+    - Vadym Popov
+    - Waldir Pimenta
+    - Wilmer Paulino
+    - benma
+    - danda
+    - dskloet
+    - esemplastic
+    - jadeblaquiere
+    - nakagawa
+    - preminem
+    - qshuai
+
 Changes in 0.12.0 (Fri Nov 20 2015)
   - Protocol and network related changes:
     - Add a new checkpoint at block height 382320 (#555)