Skip to content

Commit 42511be

Browse files
committed
simplify
1 parent 49b9f8e commit 42511be

File tree

5 files changed

+17
-11
lines changed

5 files changed

+17
-11
lines changed
Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
package seleniumtestinglib
22

3+
import org.openqa.selenium.JavascriptExecutor
34
import org.openqa.selenium.WebElement
4-
import org.openqa.selenium.remote.RemoteWebDriver
5+
import org.openqa.selenium.remote.RemoteWebElement
56

67
val WebElement.value: String?
78
get() = getAttribute("value")
89

910
val WebElement.isChecked: Boolean
1011
get() = isSelected
1112

12-
fun WebElement.isFocused(driver: RemoteWebDriver): Boolean =
13-
equals(driver.switchTo().activeElement())
13+
val WebElement.isFocused: Boolean
14+
get() = equals((this as RemoteWebElement).wrappedDriver.switchTo().activeElement())
1415

1516
@Suppress("UNCHECKED_CAST")
16-
fun WebElement.files(driver: RemoteWebDriver): List<Map<String, Any>> =
17-
driver.executeScript("return arguments[0].files", this) as List<Map<String, Any>>
17+
val WebElement.files: List<Map<String, Any>>
18+
get() = ((this as RemoteWebElement).wrappedDriver as JavascriptExecutor)
19+
.executeScript("return arguments[0].files", this) as List<Map<String, Any>>

lib/src/test/kotlin/seleniumtestinglib/coreapi/ByAltTextTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ class ByAltTextTest(private val driver: RemoteWebDriver) {
2626

2727
val result = driver.queryBy(AltText, "incredibles", mapOf("exact" to false))
2828

29+
driver.executeScript("console.log(arguments[0])", "() => throw new Exception()")
30+
2931
assertEquals("input", result?.tagName)
3032
}
3133
}

lib/src/test/kotlin/seleniumtestinglib/userinteractions/GeneralTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package seleniumtestinglib.userinteractions
22

33
import com.google.common.io.Files
4+
import org.junit.jupiter.api.Disabled
45
import org.junit.jupiter.api.extension.ExtendWith
56
import org.openqa.selenium.By
67
import org.openqa.selenium.OutputType
@@ -20,6 +21,7 @@ import kotlin.test.Test
2021
class GeneralTest(private val driver: RemoteWebDriver) {
2122

2223
@Test
24+
@Disabled
2325
fun chaining() {
2426
driver
2527
.render(

lib/src/test/kotlin/seleniumtestinglib/userinteractions/TabTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class TabTest(private val driver: RemoteWebDriver) {
3030

3131
driver.user.tab()
3232

33-
assertTrue(driver.findElement(ByRole("radio")).isFocused(driver))
33+
assertTrue(driver.findElement(ByRole("radio")).isFocused)
3434
}
3535

3636
@Test
@@ -50,7 +50,7 @@ class TabTest(private val driver: RemoteWebDriver) {
5050

5151
driver.user.tab(shift = true)
5252

53-
assertTrue(driver.findElement(ByRole("radio")).isFocused(driver))
53+
assertTrue(driver.findElement(ByRole("radio")).isFocused)
5454
}
5555

5656
@Test
@@ -68,7 +68,7 @@ class TabTest(private val driver: RemoteWebDriver) {
6868
.tab()
6969
.keyboard("{Tab}")
7070

71-
assertTrue(driver.findElement(ByRole("radio")).isFocused(driver))
71+
assertTrue(driver.findElement(ByRole("radio")).isFocused)
7272
}
7373

7474
@Test
@@ -86,7 +86,7 @@ class TabTest(private val driver: RemoteWebDriver) {
8686

8787
driver.user.keyboard("[/ShiftLeft][/ShiftRight]{Tab}")
8888

89-
assertTrue(driver.findElement(ByRole("radio")).isFocused(driver))
89+
assertTrue(driver.findElement(ByRole("radio")).isFocused)
9090
}
9191

9292
@Test
@@ -106,6 +106,6 @@ class TabTest(private val driver: RemoteWebDriver) {
106106

107107
driver.user.keyboard("{Shift>}{Tab}{/Shift}")
108108

109-
assertTrue(driver.findElement(ByRole("radio")).isFocused(driver))
109+
assertTrue(driver.findElement(ByRole("radio")).isFocused)
110110
}
111111
}

lib/src/test/kotlin/seleniumtestinglib/userinteractions/UploadTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class UploadTest(private val driver: RemoteWebDriver) {
3333
File(listOf("hello"), "hello.png", mapOf("type" to "image/png")),
3434
)
3535

36-
val upload = input.files(driver).single()
36+
val upload = input.files.single()
3737
assertEquals("hello.png", upload["name"])
3838
assertEquals("image/png", upload["type"])
3939
assertEquals("hello".length.toLong(), upload["size"])

0 commit comments

Comments
 (0)