Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub not displaying properly #23

Closed
Feripe-a opened this issue Jul 1, 2021 · 7 comments
Closed

Sub not displaying properly #23

Feripe-a opened this issue Jul 1, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Feripe-a
Copy link

Feripe-a commented Jul 1, 2021

I was watching 史上最強の弟子ケンイチ and noticed that some lines were cut due to the way the sub file is formatted.
Here's an example of the error: https://streamable.com/l8epm5
Here's the lines:
Dialogue: 0,0:02:07.12,0:02:09.37,a,,0,0,0,,(田中(たなか))\N前から\N気になってたんだけど Dialogue: 0,0:02:09.58,0:02:10.38,a,,0,0,0,,(島山(しまやま))\Nん?

Dialogue: 0,0:02:25.60,0:02:29.52,a,,0,0,0,,(田中)\Nでも 風林寺ってさ\Nどっか近寄りがたいよな Dialogue: 0,0:02:29.64,0:02:32.19,a,,0,0,0,,住んでる世界が違うっていうか…

@arianneorpilla
Copy link
Owner

I will need the subtitle file itself in order to investigate this. Thanks.

@Feripe-a
Copy link
Author

Feripe-a commented Jul 2, 2021

First I used .srt then I converted to .ass to see it the bug continues. Here it is https://www.mediafire.com/file/rm7dndn8vok27lo/subused.tar.gz/file
I was using .ass in that video.

@arianneorpilla
Copy link
Owner

Thanks for getting back to me. I'll properly investigate this in time. Do you find this issue is critical in other subtitles you use or is this a rare occasion?

@arianneorpilla arianneorpilla self-assigned this Jul 2, 2021
@arianneorpilla arianneorpilla added the bug Something isn't working label Jul 2, 2021
@Feripe-a
Copy link
Author

Feripe-a commented Jul 2, 2021

It depends. It didn't happens in Yuru Camp because each subtitle line wasn't split in two to occupy lass space on the screen (it's different from → to indicate that the sentences continues in the next line). But the way subtitles are formatted in 史上最強の弟子ケンイチ makes that bug happens in every episode. You can download all of 史上最強の弟子ケンイチ subtitles on Kitsuneko.
I've looked into my anime folder for more subs formated that way. Bleach is formatted like that as well. So if watch it with Jidoujisho, subs are likely to "get cut".

I'm a normal user, so I can't help you that much.

@Feripe-a
Copy link
Author

Feripe-a commented Jul 2, 2021

Do you find this issue is critical in other subtitles you use or is this a rare occasion?

Yes, because only the parts that appear are copied to Anki, even though it's trimmed as it's supposed to be. I just remembered it right now.

@arianneorpilla
Copy link
Owner

I have implemented a fix for this issue in 0.24.0.

See the relevant line in the release notes:

  • Fixed a critical issue related to the subtitle wrapper widget not parsing and displaying files with subtitles with more than two lines of text

Sorry that it took a while. You actually discovered an issue in this package I'm using for subtitles. I've let the maintainer know with a pull request, so thanks for the report. If there are any further issues, let me know. With that, I am closing this issue.

@Feripe-a
Copy link
Author

Feripe-a commented Jul 5, 2021

Sorry that it took a while.

You were fast, thanks.

If there are any further issues, let me know.

I'll be on the lookout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants