feat: allow GitHub source property to be split into two (#14)

GitHub custom properies have a limit of 75 characters, so we can split the host and path parts
to make it a bit more manageable

Author: lqc

src/kalandra/cli.py

@@ -115,14 +115,27 @@ async def main(cmdline_args: list[str]) -> int:
 
         logger.info("Looking up source URL from target repository")
 
-        source_url = await github_api.get_repo_property(
-            repo_url=args.target,
-            property_name=args.source[len("target-prop:") :],
-        )
-        if source_url is None:
+        props = await github_api.get_repo_properties(args.target)
+        source_prop_name = args.source[len("target-prop:") :]
+
+        if source_prop_name not in props:
             logger.error("Property %s not found in target repository", args.source)
             return 1
 
+        source_prop_value = props[source_prop_name]
+        if source_prop_value.startswith("/"):
+            # Assume it's a relative path and lookup host from another prop
+            if f"{source_prop_name}-host" not in props:
+                logger.error(
+                    "Source property is relative, but no %s-host not found in target repository: %s",
+                    args.source,
+                    source_prop_value,
+                )
+                return 1
+            source_url = props[f"{source_prop_name}-host"] + source_prop_value
+        else:
+            source_url = source_prop_value
+
     source = Transport.from_url(source_url, credentials_provider=credentials_provider)
     target = Transport.from_url(args.target, credentials_provider=credentials_provider)
 

src/kalandra/github_utils.py

@@ -49,11 +49,10 @@ def get_org_api(self, org: str) -> github.Github:
 
         return github.Github(auth=self._auth.get_installation_auth(installation_id))
 
-    async def get_repo_property(
+    async def get_repo_properties(
         self,
         repo_url: str,
-        property_name: str,
-    ) -> None | str:
+    ) -> dict[str, str]:
         url = urlparse(repo_url)
 
         path_parts = url.path.strip("/").split("/")
@@ -62,13 +61,15 @@ async def get_repo_property(
         if repo_name.endswith(".git"):
             repo_name = repo_name[:-4]
 
-        logging.info("Looking up property %s for org '%s' and repo '%s'", property_name, org, repo_name)
         api = self.get_org_api(org)
         repo = api.get_repo(f"{org}/{repo_name}")
-        value = repo.get_custom_properties().get(property_name, None)  # type: ignore
-        if value is not None and not isinstance(value, str):
-            raise ValueError(f"Property {property_name} is not a string: {value}")
-        return value
+
+        values: dict[str, str] = {}
+        for key, value in repo.custom_properties.items():  # type: ignore
+            if isinstance(value, str):
+                values[key] = value
+
+        return values
 
     def crendentials_provider_for_org(self, org: str) -> GitHubAppCredentialProvider:
         installation_id = self.get_installation_id(org)