Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel/ci] spliced mask_rom depends on meson built software #12696

Closed
Tracked by #12449
drewmacrae opened this issue May 16, 2022 · 4 comments · Fixed by #12705
Closed
Tracked by #12449

[bazel/ci] spliced mask_rom depends on meson built software #12696

drewmacrae opened this issue May 16, 2022 · 4 comments · Fixed by #12705
Assignees
Labels
Component:CI Continuous Integration (Azure Pipelines & Co.) Priority:P1 Priority: high Type:Cleanup Cleanup tasks

Comments

@drewmacrae
Copy link
Contributor

drewmacrae commented May 16, 2022

This will also include a structured release artifact, with https://github.com/bazelbuild/rules_pkg/releases

@drewmacrae drewmacrae added Priority:P1 Priority: high Type:Cleanup Cleanup tasks Component:CI Continuous Integration (Azure Pipelines & Co.) labels May 16, 2022
@drewmacrae drewmacrae self-assigned this May 16, 2022
@drewmacrae
Copy link
Contributor Author

@cfrantz @a-will Am I reading the documentation for rules_pkg correctly that it doesn't support wildcards for artifacts? In the meantime I think it might be appropriate in CI use a copying shell script until we have a better notion of what we want to add to a release and make some filesets that point to it.

@a-will
Copy link
Contributor

a-will commented May 17, 2022

Hm... I'm not sure what you mean by "wildcards for artifacts." What are you looking to do with a wildcard?

@drewmacrae
Copy link
Contributor Author

meson seems to wrap up all the products of sw/... that it knows how to build. It doesn't look to me like there's a way to do that without dropping an entry into each of 300 BUILD files.

@a-will
Copy link
Contributor

a-will commented May 18, 2022

meson seems to wrap up all the products of sw/... that it knows how to build. It doesn't look to me like there's a way to do that without dropping an entry into each of 300 BUILD files.

Mostly, meson allows us to distinguish between an OBJ_DIR and a BIN_DIR, and it happens to be convenient that the contents of the BIN_DIR is what you'd want in this case.

By contrast, bazel does not have that separation, so there isn't that convenient directory to simply copy over (without a lot of extra baggage, that is).

For what it's worth, we likely could get a representative list of targets with a bazel query, followed by some quick processing to extract the base directories and output those as prefixes to pkg_files rules. These don't need to be spread out across the BUILD files -- From any given BUILD file, we can grab any target from the workspace with the path (assuming the target doesn't restrict visibility... but we probably haven't paid close attention to that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:CI Continuous Integration (Azure Pipelines & Co.) Priority:P1 Priority: high Type:Cleanup Cleanup tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants