Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] Bazelify OpenOCD systemtest #12497

Closed
Tracked by #12449
milesdai opened this issue May 5, 2022 · 4 comments
Closed
Tracked by #12449

[bazel] Bazelify OpenOCD systemtest #12497

milesdai opened this issue May 5, 2022 · 4 comments
Assignees
@dmcardle
Labels
Component:Software Issue related to Software Priority:P1 Priority: high
Milestone
Project: M2

Comments

@milesdai
Copy link
Contributor

milesdai commented May 5, 2022

tests/systemtest/earlgrey/test_sim_verilator.py contains an additional test to check that OpenOCD connects correctly. This test needs to be converted into a py_binary Bazel rule and moved into sw/host/tests.
@milesdai milesdai self-assigned this May 5, 2022
This was referenced May 5, 2022
Closed
Merged
@arunthomas arunthomas assigned drewmacrae and unassigned milesdai Jun 2, 2022
@moidx moidx assigned dmcardle and unassigned drewmacrae Aug 26, 2022
@moidx moidx added this to the Project: M2 milestone Aug 26, 2022
@dmcardle
Copy link
Contributor

Looks like test_sim_verilator.py was deleted in #12929. Actually, I think the referenced test was removed earlier in #12482. @milesdai, could you confirm whether test_openocd_basic_connectivity need to be recreated?

@dmcardle
Copy link
Contributor

dmcardle commented Sep 7, 2022

@milesdai, can you help me with the archaeology on this one?

@milesdai
Copy link
Contributor Author

milesdai commented Sep 7, 2022

Ah yes, this test written in python that made sure that openocd could connect to the FPGA, and that was about it. Given #14343, when we start running SRAM tests, this will probably be unnecessary since each test will be exercising the openocd connectivity.

@dmcardle
Copy link
Contributor

dmcardle commented Sep 7, 2022

Thanks for confirming, Miles! I'll close this as "won't-fix".

@dmcardle dmcardle closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmcardle dmcardle

Labels
Component:Software Issue related to Software Priority:P1 Priority: high
Projects
None yet
Milestone
Project: M2
Development

No branches or pull requests
4 participants
@dmcardle @drewmacrae @moidx @milesdai