You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since this type of backlight control is specific to the particular Panel_LCD, I wonder if any of these minor refactors would be appropriate:
// additional class to be mixed in when appropriate and manually called by the user if neededclassIPanel_LCD_InteractiveBacklight {
// (1) panel is capable of creating an ILight instance which references this panel for commandsvirtual ILight* createLight() = 0;
// ... or ...// (2) panel directly exposes a `setBrightness`, and a new `Light_InteractivePanel` class// would simply defer to thisvirtualvoidsetBrightness(...) = 0;
};
// ... or ...classPanel_SSD1963 {
public:// (3) panel defines its own `ILight` impl to be explicitly created by the user and assigned to `LGFX_Device`classLight : ILight { ... };
};
// ... or ...classPanel_Device {
// ...// (4) all panels may directly offer a `ILight`; panels like SSD1963 will always have backlight control//// if no `ILight` was specifically assigned to `LGFX_Device`, then it would defer to // the panelvirtual ILight* getLight() { returnnullptr; };
// ...
};
(2) seems most in line with current LGFX patterns
The text was updated successfully, but these errors were encountered:
(Moved from #583 )
Some panels, i.e. SSD1963, come with built-in backlight control which require device-specific commands to manage.
Currently there isn't any
ILight
implementation which supports this.For SSD1963 specifically, these commands are needed for backlight control:
Since this type of backlight control is specific to the particular
Panel_LCD
, I wonder if any of these minor refactors would be appropriate:(2) seems most in line with current LGFX patterns
The text was updated successfully, but these errors were encountered: