Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional states "events", "caret", "typing", "plaintext-only" #84

Open
dinukadesilva opened this issue Mar 31, 2018 · 2 comments · May be fixed by #85
Open

Additional states "events", "caret", "typing", "plaintext-only" #84

dinukadesilva opened this issue Mar 31, 2018 · 2 comments · May be fixed by #85
Labels
enhancement

Comments

@dinukadesilva
Copy link

https://w3c.github.io/editing/contentEditable.html#h-contenteditable

According to the current implementation, how about enabling these via props. For now, only the disabled prop is there to toggle between "true" and "false" states. So, I was just wondering how about having the other states too as props

Any thoughts?
dinukadesilva added a commit to dinukadesilva/react-contenteditable that referenced this issue Mar 31, 2018
@dinukadesilva
lovasoagh-84: Addition additional states of contenteditable
6d9974a 
This fixes lovasoa#84
@dinukadesilva dinukadesilva linked a pull request Mar 31, 2018 that will close this issue
Open
dinukadesilva added a commit to dinukadesilva/react-contenteditable that referenced this issue Mar 31, 2018
@dinukadesilva
lovasoagh-84: Addition additional states of contenteditable
1821e5f 
This fixes lovasoa#84
dinukadesilva added a commit to dinukadesilva/react-contenteditable that referenced this issue Mar 31, 2018
@dinukadesilva
lovasoagh-84: Addition additional states of contenteditable
a30669a 
This fixes lovasoa#84
@mmathys
Copy link

mmathys commented Apr 3, 2018 •
edited
Loading

good PR, but it's much cleaner to put all of these elements in a the single array on L46.. You can avoid all if statements this way

@mmathys
Copy link

mmathys commented Apr 3, 2018

By the way, events like onClick, onFocus, onBlur would also be useful

@mmathys mmathys mentioned this issue Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#84: Addition additional states of contenteditable dinukadesilva/react-contenteditable
3 participants
@lovasoa @mmathys @dinukadesilva