esm: fix inconsistency with importAssertion in resolve hook

As the documentation states, the `context.importAssertion` should be
still supported and emit a warning. This is true for the `load` hook,
but not correct for context of the `resolve` hook.

This commit fixes the inconsistency.

PR-URL: nodejs#55365
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Author: yesmeck

lib/internal/modules/esm/hooks.js

@@ -237,7 +237,7 @@ class Hooks {
 
     const nextResolve = nextHookFactory(chain[chain.length - 1], meta, { validateArgs, validateOutput });
 
-    const resolution = await nextResolve(originalSpecifier, context);
+    const resolution = await nextResolve(originalSpecifier, defineImportAssertionAlias(context));
     const { hookErrIdentifier } = meta; // Retrieve the value after all settled
 
     validateOutput(hookErrIdentifier, resolution);

test/es-module/test-esm-import-assertion-warning.mjs

@@ -7,6 +7,11 @@ await Promise.all([
   `data:text/javascript,export ${encodeURIComponent(function resolve() {
     return { shortCircuit: true, url: 'data:application/json,1', importAssertions: { type: 'json' } };
   })}`,
+  // Using importAssertions on the context object of the resolve hook should warn but still work.
+  `data:text/javascript,export ${encodeURIComponent(function resolve(s, c, n) {
+    const type = c.importAssertions.type;
+    return { shortCircuit: true, url: 'data:application/json,1', importAttributes: { type: type ?? 'json' } };
+  })}`,
   // Setting importAssertions on the context object of the load hook should warn but still work.
   `data:text/javascript,export ${encodeURIComponent(function load(u, c, n) {
     c.importAssertions = { type: 'json' };
@@ -22,9 +27,9 @@ await Promise.all([
     '--eval', `
     import assert from 'node:assert';
     import { register } from 'node:module';
-    
+
     register(${JSON.stringify(loaderURL)});
-    
+
     assert.deepStrictEqual(
       { ...await import('data:') },
       { default: 1 }

test/fixtures/es-module-loaders/hooks-input.mjs

@@ -37,6 +37,7 @@ export async function resolve(specifier, context, next) {
     'conditions',
     'importAttributes',
     'parentURL',
+    'importAssertions',
   ]);
   assert.ok(Array.isArray(context.conditions));
   assert.strictEqual(typeof next, 'function');
@@ -71,9 +72,10 @@ export async function load(url, context, next) {
 
   assert.ok(new URL(url));
   // Ensure `context` has all and only the properties it's supposed to
-  assert.deepStrictEqual(Object.keys(context), [
+  assert.deepStrictEqual(Reflect.ownKeys(context), [
     'format',
     'importAttributes',
+    'importAssertions',
   ]);
   assert.strictEqual(context.format, 'test');
   assert.strictEqual(typeof next, 'function');