Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote text is truncated and tags aren't closed #24

Open
jramnani opened this issue Dec 28, 2018 · 0 comments
Open

Blockquote text is truncated and tags aren't closed #24

jramnani opened this issue Dec 28, 2018 · 0 comments

Comments

@jramnani
Copy link

Given I am using the preference setting, "Wrap selected text on a page with <blockquote> in the Notes field"
And I highlight a paragraph of text on the current page
Then after a certain length the highlighted text is truncated with '...'. The <blockquote> tag isn't even closed. This happens with strings less than the limit Pinboard sets on the Description/Notes field.

Expected behavior: All of the text I highlighted should appear within the <blockquote></blockquote> section, and the <blockquote> tag should be closed.

Example:

Given this page: https://twistedmatrix.com/documents/current/core/howto/defer.html

Highlighted text:

This document is a guide to the behaviour of the twisted.internet.defer.Deferred object, and to 
various ways you can use them when they are returned by functions.

This document assumes that you are familiar with the basic principle that the Twisted framework is 
structured around: asynchronous, callback-based programming, where instead of having blocking 
code in your program or using threads to run blocking code, you have functions that return 
immediately and then begin a callback chain when data is available.

The resulting Notes field looks like this:

<blockquote>This document is a guide to the behaviour of the twisted.internet.defer.Deferred 
object, and to various ways you can use them when they are returned by functions.

This document assumes that you are familiar with the basic principle that the Twisted framework is 
structured around: asynchronous, callback-based programming, where instead of having blocking 
code in your program or using threads to run blocking code, you have functions that return 
immediately and then begin a callback ch...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant